Jira 797, Central can scan with MAC address, git 376 #416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New feature:
- Add the capability for a Central to scan for a
Peripheral using its MAC address.
Code Modifications:
- Added the API for MAC address scanning.
- For Device Manager, added provision for holding the
MAC address of a Peripheral.
- For scan discovery handler, added the checking
for MAC address comparison, if MAC address scanning
is requested.
File changes:
1. libraries/CurieBLE/src/BLEDevice.cpp:
- Added API for MAC address scanning.
2. libraries/CurieBLE/src/BLEDevice.h:
- API definition.
3. libraries/CurieBLE/src/internal/BLEDeviceManager.cpp:
- Added provision for storing the MAC address.
- Added MAC address comparison in the scan discovery
handle if MAC address scanning is selected.
4. libraries/CurieBLE/src/internal/BLEDeviceManager.h:
- Prototyping.
|
@bigdinotech @eriknyquist , please review the code change. @noelpaz @russmcinnis , please note that this PR is originated from PR #397. If you have tested it against Jira #797, please wait for code approval to perform final verification prior to merging. |
eriknyquist
approved these changes
Feb 1, 2017
|
@noelpaz @russmcinnis , please confirm if this PR passed verification testing. |
|
@noelpaz , @russmcinnis , please provide feedback to close out this PR. |
|
It passed verification testing |
bigdinotech
approved these changes
Feb 7, 2017
|
@yashaswini-hanji @calvinatintel , would you please merge this PR to the main trunk. It has gone through code approval and testing. Please close the PR upon merge completion. |
|
Changes merged to base branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature:
Peripheral using its MAC address.
Code Modifications:
MAC address of a Peripheral.
for MAC address comparison, if MAC address scanning
is requested.
File changes:
handle if MAC address scanning is selected.